-
Notifications
You must be signed in to change notification settings - Fork 1
Add about dialog #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add about dialog #171
Conversation
Closes #120.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Settings are stored in works amazing 👍🏼
The about says version 0.0.1 for me for some reason?
And I don't find it in the Help -> About but Mac puts it automatically into the About Python. Seems to be a classical Mac thing again (just as quit)
Are you using and editable installation? Does it work after reinstalling the package?
For me (Ubuntu) it shows up as |
on macOS quit, About and Preferences should always be on the Application menu (where for now it still says |
Thanks.
Now? (I don't have any macos.) |
|
Version shows now correct for me. It is now called python3.12. I tried renaming it to PEtabGUI before as well with no success. I think this is fine, as it is a byproduct of this not being an official app (as far as I understood). Would be fine to merge. |
👍
@fbergmann Any ideas on how to change the application name on macos? |
|
Any idea whether this can be done for Python package entrypoints? https://stackoverflow.com/questions/16427221/how-do-i-change-my-qt-app-name-on-the-mac-os-x-system-menu (Without pyinstaller or the like) |
|
@dweindl I've tried it on a mac now, and it does work, though it requires the --- a/src/petab_gui/app.py
+++ b/src/petab_gui/app.py
@@ -132,6 +132,14 @@ def main():
)
args = parser.parse_args()
+ if sys.platform == "darwin":
+ from Foundation import NSBundle
+ bundle = NSBundle.mainBundle()
+ info = bundle.localizedInfoDictionary() or bundle.infoDictionary()
+ info["CFBundleName"] = "PEtab GUI"
+
app = PEtabGuiApp(args.petab_yaml)
sys.exit(app.exec()) |
Cool, thanks. I added that. Someone please confirm that it works (including installing the dependencies). |
|
@dweindl i can confirm that it does work on macos as expected |
Closes #120.