KeyError: 'conditionId'

[dweindl]

1. Open Bruno benchmark problem
2. Change some simulationConditionId

expected: No error on the console

actual:

Traceback (most recent call last):
  File "PEtab_GUI/env/lib/python3.13/site-packages/pandas/core/indexes/base.py", line 3812, in get_loc
    return self._engine.get_loc(casted_key)
           ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^
  File "pandas/_libs/index.pyx", line 167, in pandas._libs.index.IndexEngine.get_loc
  File "pandas/_libs/index.pyx", line 196, in pandas._libs.index.IndexEngine.get_loc
  File "pandas/_libs/hashtable_class_helper.pxi", line 7088, in pandas._libs.hashtable.PyObjectHashTable.get_item
  File "pandas/_libs/hashtable_class_helper.pxi", line 7096, in pandas._libs.hashtable.PyObjectHashTable.get_item
KeyError: 'conditionId'

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "PEtab_GUI/src/petab_gui/controllers/mother_controller.py", line 211, in <lambda>
    else self.condition_controller.maybe_add_condition(x, y)
         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^
  File "PEtab_GUI/src/petab_gui/controllers/table_controllers.py", line 1039, in maybe_add_condition
    self.model.fill_row(
    ~~~~~~~~~~~~~~~~~~~^
        self.model.get_df().shape[0] - 1,
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        data={"conditionId": condition_id},
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    )
    ^
  File "PEtab_GUI/src/petab_gui/models/pandas_table_model.py", line 956, in fill_row
    self.get_default_values(
    ~~~~~~~~~~~~~~~~~~~~~~~^
        self.index(row_position, 0),
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        changed=changes,
        ^^^^^^^^^^^^^^^^
    )
    ^
  File "PEtab_GUI/src/petab_gui/models/pandas_table_model.py", line 999, in get_default_values
    default_value = self.default_handler.get_default(
        colname, row_key, changed=changed
    )
  File "PEtab_GUI/src/petab_gui/controllers/default_handler.py", line 69, in get_default
    if np.issubdtype(self.model.dtypes[column_name], np.floating):
                     ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^
  File "PEtab_GUI/env/lib/python3.13/site-packages/pandas/core/series.py", line 1130, in __getitem__
    return self._get_value(key)
           ~~~~~~~~~~~~~~~^^^^^
  File "PEtab_GUI/env/lib/python3.13/site-packages/pandas/core/series.py", line 1246, in _get_value
    loc = self.index.get_loc(label)
  File "PEtab_GUI/env/lib/python3.13/site-packages/pandas/core/indexes/base.py", line 3819, in get_loc
    raise KeyError(key) from err
KeyError: 'conditionId'

Tested with d484231, petab==0.6.0

[PaulJonasJost]

could not reproduce on same commit when changing simulationConditionId in the measurement table, it did so without complaints. It did throw an error when renaming one in condition table though! will checkout

[dweindl]

could not reproduce on same commit when changing simulationConditionId in the measurement table, it did so without complaints.

Okay, I should have been be more specific: This only happens when changing simulationConditionId to some non-existing condition ID.

I don't fully understand the logic, but my feeling is, that this get_default call should not happen for the table index in this situation:

https://github.com/PaulJonasJost/PEtab_GUI/blob/50f26449992af4d548308d08fa2972c58037646a/src/petab_gui/models/pandas_table_model.py#L1001-L1003