Repository navigation
Conversation
…st deterministic suffix, newest-first relations, declared observables).
…arify a test comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1362 (the MX fix), because the replay must execute MX as H, MZ, H. This PR retargets to dev when that one merges.
Adds code-agnostic detector discovery for Clifford
TickCircuits:pecos.qec.discover_detectors(tc, observables=()), backed bypecos_qec::fault_tolerance::detector_discovery::discover_detectors.Rule
symbolic_measurement_historyis factored so that the full history and the suffix probes share one gate table.symbolic_measurement_historykeeps its exact behaviour and errors.A simpler choice, picking each detector by shrinking the set of faults that flip it, was tried first and rejected. On surface final readouts it fell into local minima. Choosing by when determinism is established reproduces the hand-built detectors exactly.
Verification
cargo test -p pecos-qec: 1355 passed;qec-guppyshard,python-ci-lintand pre-commit pass.Known limitation, pre-existing
#1360:
SymbolicSparseStab::pzpostselects instead of resetting when the qubit is entangled and unmeasured. Discovery inherits that, so circuits that reset an entangled qubit without measuring it can get a wrong detector. Surface memory and gadget circuits only reset after measuring and are unaffected. The fix is tracked in #1360.A
MeasureLeakeddependency inside a backward probe raises the shared replay error, even when the full history is representable. This is documented on the function.