Controllers: Make restore defaults restore controller LED #12264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheTechnician27
force-pushed
the
controllerdefaults
branch
from
33d83e1 to
af766ce
Compare
JordanTheToaster
approved these changes
Feb 3, 2025
F0bes
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Makes it so that the
Restore Defaultsbutton in thePCSX2 Controller Settingsrestores the default LED colors for the four players. This takes effect immediately.Rationale behind Changes
Restore Defaultspreviously did not reset the controller LED colors set by the user, when it should reset all controller settings.Suggested Testing Steps
Go to
Settings>Controllersand click the little lightbulb next toDualShock 4 / DualSense Enhanced Mode. Set all the ports to something obviously non-default. ThenRestore Defaultseither before you've exited out of PCSX2 or after reopening the application. If you have a DS4 or DS5 controller, check to ensure that this immediately changes the physical LED color on your controller.