Skip to content

[BUG]: Breakpoint's Instrumentation settings aren't saved #15001

Description

@Kamayana

Describe the Bug

The new breakpoint instrumentation options added in #14557 aren't saved with the rest of the breakpoint settings, so whenever you close the program or load settings your changes are lost. Note their absence from breakpoint data. This limits their usability a fair bit, since I don't want to put in the effort of detailed logpoints if they're just going to be lost once I exit the program.

Reproduction Steps

  1. Create a breakpoint. Edit all of the options from their default values, like so:
Image
  1. Right-click in the breakpoint table and select "Save to Settings".

  2. Right-click in the breakpoint table and select "Load from Settings" to load from the settings we just saved.

  3. Right-click the breakpoint and select "Edit" to see how not all of the settings were saved. The Max Hit Count and Log When Hit settings have all reset to default:

Image

Expected Behavior

I'd expect all the breakpoint settings in the edit window to be saved and preserved, not that some are only for the current session.

PCSX2 Revision

v2.9.81

Operating System

Windows 11

If Linux - Specify Distro

No response

Logs & Dumps

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions