define SLJIT_UPDATE_WX_FLAGS when !TARGET_OS_OSX for ios cross compile
#251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ghost-LZW
changed the title
SLJIT_UPDATE_WX_FLAGS for ios cross compile
…mpile To avoid `implicit declaration of function 'SLJIT_UPDATE_WX_FLAGS' is invalid in C99`
Ghost-LZW
force-pushed
the
fix_no_osx_build
branch
from
c6df5b9
to
58c1069
Compare
Ghost-LZW
changed the title
SLJIT_UPDATE_WX_FLAGS for ios cross compileSLJIT_UPDATE_WX_FLAGS when !TARGET_OS_OSX for ios cross compile
carenas
suggested changes
May 10, 2023
There was a problem hiding this comment.
If one implementation is to be provided, it will need to be added to sljit first, and is unlikely to work because of Apple policy (see zherczeg/sljit#156)
| @@ -90,6 +90,7 @@ static SLJIT_INLINE void apple_update_wx_flags(sljit_s32 enable_exec) | |||
| #endif /* SLJIT_CONFIG_X86 */ | |||
| #else /* !TARGET_OS_OSX */ | |||
| #define SLJIT_MAP_JIT (MAP_JIT) | |||
| #define SLJIT_UPDATE_WX_FLAGS(from, to, enable_exec) | |||
There was a problem hiding this comment.
this is incorrect; iOS needs an implementation for this function and so the build breaking (or showing a warning that says one is missing) is more accurate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid
implicit declaration of function 'SLJIT_UPDATE_WX_FLAGS' is invalid in C99