Skip to content

Conversation

@jamesrweb
Copy link
Member

@jamesrweb jamesrweb commented Jul 30, 2025

Related Issue

Fixes #519

PR Type

  • πŸ› Bug Fix
  • ✨ New Feature
  • πŸ”¨ Code Refactor
  • πŸ“ Documentation Update
  • πŸ§ͺ Test Update
  • πŸ”§ Build/CI Update
  • 🧹 Chore
  • βͺ Revert

Description

Adds an example of how to use p5.record with the wrapper.

Proposed Changes

  • Add a new example sketch
  • Update the existing html template to show the play, pause, stop and resume buttons when using the p5.record example
  • Updated project dependencies

How Has This Been Tested?

  • Unit Tests
  • Integration Tests
  • Manual Testing (please describe)

Screenshots/Recordings

Recording.1.webm

Breaking Changes

  • Yes (please describe)
  • No

Checklist

  • My code follows the code style of this project
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • My changes generate no new warnings

Additional Notes

N / A

@jamesrweb jamesrweb requested a review from yevdyko as a code owner July 30, 2025 12:13
@jamesrweb jamesrweb self-assigned this Jul 30, 2025
@jamesrweb jamesrweb added the documentation Pull requests that update project documentation label Jul 30, 2025
@github-actions
Copy link

Coverage report for commit: e1c6d99
File: ./coverage/clover.xml

Cover β”Œβ”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β” Freq.
   0% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
  10% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
  20% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
  30% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
  40% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
  50% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
  60% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
  70% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
  80% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
  90% β”‚ β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘β–‘ β”‚  0.0%
 100% β”‚ β–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆ β”‚ 100.0%
      β””β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”€β”˜
 *Legend:* β–ˆ = Current Distribution 
Summary - Lines: 100.00% | Methods: 100.00% | Branches: 91.30%
FilesLinesMethodsBranches
src/components
Β  Β ReactP5Wrapper.tsx100.00%100.00%100.00%
Β  Β ReactP5WrapperGuard.tsx100.00%100.00%72.73%
Β  Β ReactP5WrapperWithSketch.tsx100.00%100.00%88.89%
src/constants
Β  Β P5WrapperClassName.ts100.00%100.00%100.00%
src/contracts
Β  Β CanvasInstanceRef.ts100.00%100.00%100.00%
Β  Β InputProps.ts100.00%100.00%100.00%
Β  Β P5CanvasInstance.ts100.00%100.00%100.00%
Β  Β P5WrapperProps.ts100.00%100.00%100.00%
Β  Β P5WrapperPropsWithSketch.ts100.00%100.00%100.00%
Β  Β Sketch.ts100.00%100.00%100.00%
Β  Β SketchProps.ts100.00%100.00%100.00%
Β  Β WithChildren.ts100.00%100.00%100.00%
Β  Β Wrapper.ts100.00%100.00%100.00%
Β  Β WrapperRef.ts100.00%100.00%100.00%
src
Β  Β main.tsx100.00%100.00%100.00%
src/utils
Β  Β createCanvasInstance.ts100.00%100.00%100.00%
Β  Β logErrorBoundaryError.ts100.00%100.00%100.00%
Β  Β propsAreEqual.ts100.00%100.00%100.00%
Β  Β removeCanvasInstance.ts100.00%100.00%100.00%
Β  Β updateCanvasInstance.ts100.00%100.00%100.00%
Β  Β withoutKeys.ts100.00%100.00%100.00%

πŸ€– comment via lucassabreu/comment-coverage-clover

@jamesrweb jamesrweb added the security This label applies to security issues label Jul 30, 2025
@jamesrweb jamesrweb enabled auto-merge July 30, 2025 17:49
@jamesrweb jamesrweb merged commit cf00354 into master Aug 4, 2025
10 checks passed
@jamesrweb jamesrweb deleted the p5-record-example branch August 4, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests that update project documentation security This label applies to security issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Yet another plugin request.

2 participants