Skip to content

Update automated updates workflow #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2022

Conversation

jamesrweb
Copy link
Collaborator

Proposed Changes

  • Prefer PR generation action defaults and recommendations

@jamesrweb jamesrweb added dependencies Pull requests that update a dependency file documentation Pull requests that update project documentation labels Sep 12, 2022
@jamesrweb jamesrweb requested a review from a team September 12, 2022 09:48
@jamesrweb jamesrweb self-assigned this Sep 12, 2022
@jamesrweb jamesrweb requested review from yevdyko and removed request for a team September 12, 2022 09:48
Copy link
Collaborator Author

@jamesrweb jamesrweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the action documentation before merging to be sure you don't want to add or remove anything else 👍🏻.

@jamesrweb jamesrweb enabled auto-merge (squash) September 12, 2022 09:51
@yevdyko
Copy link
Collaborator

yevdyko commented Sep 12, 2022

@jamesrweb Do we really need to run it daily since it can make a lot of noise if it creates minor PRs often? Is it for testing?

@jamesrweb
Copy link
Collaborator Author

@jamesrweb Do we really need to run it daily since it can make a lot of noise if it creates minor PRs often? Is it for testing?

Exactly, for testing until we get it "right".

@yevdyko
Copy link
Collaborator

yevdyko commented Sep 12, 2022

@jamesrweb Do we really need to run it daily since it can make a lot of noise if it creates minor PRs often? Is it for testing?

Exactly, for testing until we get it "right".

This makes sense. I also added labels and team-reviewers. Do we need to have a custom title since the default one "Changes by create-pull-request action" is not relevant to us?

@jamesrweb
Copy link
Collaborator Author

@jamesrweb Do we really need to run it daily since it can make a lot of noise if it creates minor PRs often? Is it for testing?

Exactly, for testing until we get it "right".

This makes sense. I also added labels and team-reviewers. Do we need to have a custom title since the default one "Changes by create-pull-request action" is not relevant to us?

Sure, feel free to add a custom one to the review then.

For the team reviewers the only issue might be that the default GITHUB_TOKEN might not have the right permissions but only one way to find out!

@yevdyko
Copy link
Collaborator

yevdyko commented Sep 12, 2022

@jamesrweb Do we really need to run it daily since it can make a lot of noise if it creates minor PRs often? Is it for testing?

Exactly, for testing until we get it "right".

This makes sense. I also added labels and team-reviewers. Do we need to have a custom title since the default one "Changes by create-pull-request action" is not relevant to us?

Sure, feel free to add a custom one to the review then.

For the team reviewers the only issue might be that the default GITHUB_TOKEN might not have the right permissions but only one way to find out!

Yes, we can check the reviewers tomorrow morning after the script runs, otherwise we will set our account names explicitly

Copy link
Collaborator

@yevdyko yevdyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesrweb I think so far so good, the rest can be adjusted tomorrow after seeing the results.

@jamesrweb jamesrweb merged commit 50ce651 into master Sep 12, 2022
@jamesrweb jamesrweb deleted the update-automated-updates-workflow branch September 12, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Pull requests that update project documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants