-
Notifications
You must be signed in to change notification settings - Fork 49
Update automated updates workflow #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the action documentation before merging to be sure you don't want to add or remove anything else 👍🏻.
@jamesrweb Do we really need to run it daily since it can make a lot of noise if it creates minor PRs often? Is it for testing? |
Exactly, for testing until we get it "right". |
This makes sense. I also added |
Sure, feel free to add a custom one to the review then. For the team reviewers the only issue might be that the default GITHUB_TOKEN might not have the right permissions but only one way to find out! |
Yes, we can check the reviewers tomorrow morning after the script runs, otherwise we will set our account names explicitly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jamesrweb I think so far so good, the rest can be adjusted tomorrow after seeing the results.
Proposed Changes