Skip to content

Split CI Jobs #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 16, 2022
Merged

Split CI Jobs #179

merged 3 commits into from
Aug 16, 2022

Conversation

jamesrweb
Copy link
Collaborator

@jamesrweb jamesrweb commented Aug 13, 2022 •
edited
Loading

Fixes #176

Proposed Changes

  • Split composite job into individual jobs
  • Utilise the new setup job which each other job depends upon

Additional Notes (optional)

N / A

@jamesrweb jamesrweb added enhancement documentation Pull requests that update project documentation labels Aug 13, 2022
@jamesrweb jamesrweb requested a review from a team August 13, 2022 18:53
@jamesrweb jamesrweb self-assigned this Aug 13, 2022
@jamesrweb jamesrweb requested review from yevdyko and removed request for a team August 13, 2022 18:53
@jamesrweb jamesrweb enabled auto-merge (squash) August 13, 2022 18:53
@jamesrweb jamesrweb marked this pull request as draft August 13, 2022 18:58
auto-merge was automatically disabled August 13, 2022 18:58

Pull request was converted to draft

yevdyko
yevdyko reviewed Aug 14, 2022
View reviewed changes
.github/workflows/CD.yml Outdated
@@ -7,20 +7,20 @@ on:
concurrency: cd-${{ github.ref }}

jobs:
build-and-deploy:
setup:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use the same setup in CI and CD workflows. What about using action composition to reduce duplication? Is this possible here?

https://github.blog/changelog/2021-08-25-github-actions-reduce-duplication-with-action-composition/

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current setup I've made doesn't even work, it seems not likely to either. Once I get things working somehow, then I will take a look at that, thanks for the tip! Seems interesting😇

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a shared job for both places 🚀!

@jamesrweb jamesrweb force-pushed the split-ci-jobs branch 2 times, most recently from bbb8f9c to 31262e4 Compare August 15, 2022 13:30
@jamesrweb jamesrweb requested a review from yevdyko August 16, 2022 10:43
@jamesrweb jamesrweb marked this pull request as ready for review August 16, 2022 16:00
@jamesrweb jamesrweb enabled auto-merge (squash) August 16, 2022 16:00
@jamesrweb
Copy link
Collaborator Author

jamesrweb commented Aug 16, 2022 •
edited
Loading

@yevdyko working! 🚀

Please review the two open PRs as soon as you get time. 🎁

@jamesrweb jamesrweb changed the base branch from master to type-updates-error-handling-guard August 16, 2022 16:03
@jamesrweb
Copy link
Collaborator Author

jamesrweb commented Aug 16, 2022 •
edited
Loading

@yevdyko I moved the base because the other PR is bugging out waiting for the build task that is required in settings now and so it needs the new flows to correct itself 👍🏻

@jamesrweb jamesrweb merged commit 09173ac into type-updates-error-handling-guard Aug 16, 2022
@jamesrweb jamesrweb deleted the split-ci-jobs branch August 16, 2022 16:11
@jamesrweb
Copy link
Collaborator Author

The PR automerged due to repo settings 🤷🏻‍♂️... didn't expect that actually... but it's okay since the target was the other PR anyway 😄

@jamesrweb jamesrweb mentioned this pull request Aug 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yevdyko yevdyko Awaiting requested review from yevdyko

Assignees

@jamesrweb jamesrweb

Labels
documentation Pull requests that update project documentation enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Split the build CI job into smaller parts
2 participants
@jamesrweb @yevdyko