Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: small cleanups #257

Merged
merged 1 commit into from
Feb 24, 2025
Merged

chore: small cleanups #257

merged 1 commit into from
Feb 24, 2025

Conversation

P403n1x87
Copy link
Owner

No description provided.

@P403n1x87 P403n1x87 force-pushed the chore/small-cleanups branch from 43ac130 to 10dca91 Compare February 23, 2025 11:27
@P403n1x87 P403n1x87 force-pushed the chore/small-cleanups branch from 10dca91 to 4ee62ac Compare February 23, 2025 11:33
@github-actions GitHub Actions
Copy link

Austin Benchmarks

Running Austin benchmarks with Python 3.13.2

Benchmark Summary

Comparison of dev against 3.7.0.

The following scenarios show a statistically significant difference in performance between the two versions.

Sample Rate Saturation Error Rate Sampling Speed
Wall time [sampling interval: 1] 🟡 🟡 🟢 🟡
Wall time [sampling interval: 10] 🟡 🟡 🟢 🟢
Wall time [sampling interval: 100] 🟡 🟢 🟢 🟡
Wall time [sampling interval: 1000] 🟡 🟡 🟢 🟡
CPU time [sampling interval: 1] 🔴 🟡 🟢 🔴
CPU time [sampling interval: 10] 🔴 🟡 🟢 🔴
CPU time [sampling interval: 100] 🟡 🟡 🟢 🔴
CPU time [sampling interval: 1000] 🟡 🟡 🟢 🔴
RSA keygen [sampling interval: 1] 🟢 🟡 🟢 🟢
RSA keygen [sampling interval: 10] 🟢 🟡 🟢 🟢
RSA keygen [sampling interval: 100] 🔴 🟢 🟢 🟢
RSA keygen [sampling interval: 1000] 🟡 🟡 🟢 🟡
Full metrics [sampling interval: 1] 🟡 🟡 🟢 🟡
Full metrics [sampling interval: 10] 🟡 🟡 🟢 🟡
Full metrics [sampling interval: 100] 🟡 🟡 🟢 🟡
Full metrics [sampling interval: 1000] 🟡 🟡 🟢 🟡
Multiprocess wall time [sampling interval: 1] 🟢 🟡 🟢 🟢
Multiprocess wall time [sampling interval: 10] 🟢 🟡 🟢 🟢
Multiprocess wall time [sampling interval: 100] 🟢 🟢 🟢 🟢
Multiprocess wall time [sampling interval: 1000] 🟢 🟢 🟢 🟢

Benchmark Results

Wall time [sampling interval: 1]

Wall time [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 55000 ± 1000 1 ± 0 0.0002 ± 8e-05 31.7 ± 0.5
dev 54000 ± 2000 1 ± 0 5e-06 ± 5e-06 31.3 ± 0.7
Wall time [sampling interval: 10]

Wall time [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 55000 ± 2000 1 ± 0 0.00022 ± 4e-05 31.9 ± 0.9
dev 55000 ± 2000 1 ± 0 5e-06 ± 7e-06 31.0 ± 0.7
Wall time [sampling interval: 100]

Wall time [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 12100 ± 300 0.0005 ± 0.0003 0.0004 ± 0.0001 35 ± 1
dev 12100 ± 300 0.0002 ± 0.0002 0 ± 0 34 ± 1
Wall time [sampling interval: 1000]

Wall time [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 1872.5 ± 0.8 0 ± 0 0.0004 ± 0.0004 36 ± 2
dev 1840 ± 40 0 ± 0 0 ± 0 37.3 ± 0.7
CPU time [sampling interval: 1]

CPU time [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 21000 ± 300 1 ± 0 0.0011 ± 0.0001 42.3 ± 0.8
dev 18800 ± 800 1 ± 0 3e-05 ± 1e-05 46 ± 1
CPU time [sampling interval: 10]

CPU time [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 20800 ± 700 1 ± 0 0.0012 ± 0.0001 42 ± 1
dev 18000 ± 2000 1 ± 0 1e-05 ± 1e-05 46 ± 2
CPU time [sampling interval: 100]

CPU time [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 6180 ± 20 0.0022 ± 0.0009 0.0019 ± 0.0004 47 ± 1
dev 6170 ± 10 0.002 ± 0.002 5e-05 ± 8e-05 50 ± 1
CPU time [sampling interval: 1000]

CPU time [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 944 ± 1 0.0001 ± 0.0002 0.002 ± 0.001 50 ± 2
dev 943 ± 2 0 ± 0 0 ± 0 54 ± 3
RSA keygen [sampling interval: 1]

RSA keygen [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 20400 ± 600 1 ± 0 0.015 ± 0.008 48 ± 1
dev 25000 ± 1000 1 ± 0 0.0002 ± 0.0005 40 ± 2
RSA keygen [sampling interval: 10]

RSA keygen [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 20000 ± 2000 1 ± 0 0.012 ± 0.007 49 ± 5
dev 24700 ± 400 1 ± 0 0.0001 ± 0.0002 39.7 ± 0.7
RSA keygen [sampling interval: 100]

RSA keygen [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 6190 ± 10 0.02 ± 0.007 0.019 ± 0.005 52.7 ± 0.9
dev 6170 ± 10 0.0008 ± 0.0007 0.0001 ± 0.0003 43 ± 1
RSA keygen [sampling interval: 1000]

RSA keygen [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 940 ± 1 0 ± 0 0.02 ± 0.01 55 ± 3
dev 939 ± 1 0 ± 0 0 ± 0 51 ± 5
Full metrics [sampling interval: 1]

Full metrics [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 29600 ± 800 1 ± 0 0.0009 ± 0.0001 56 ± 1
dev 30000 ± 1000 1 ± 0 1e-05 ± 1e-05 55 ± 1
Full metrics [sampling interval: 10]

Full metrics [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 29900 ± 700 1 ± 0 0.00085 ± 7e-05 55 ± 1
dev 29500 ± 700 1 ± 0 1.9e-05 ± 9e-06 55 ± 1
Full metrics [sampling interval: 100]

Full metrics [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 11800 ± 200 0.008 ± 0.003 0.0014 ± 0.0003 60 ± 2
dev 12100 ± 300 0.006 ± 0.001 1e-05 ± 2e-05 61 ± 2
Full metrics [sampling interval: 1000]

Full metrics [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 1850 ± 30 0 ± 0 0.0009 ± 0.0004 64 ± 3
dev 1850 ± 40 0 ± 0 0 ± 0 62 ± 3
Multiprocess wall time [sampling interval: 1]

Multiprocess wall time [sampling interval: 1]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 3000 ± 100 1 ± 0 0.0025 ± 0.0003 300 ± 10
dev 3280 ± 40 1 ± 0 2e-06 ± 8e-06 266 ± 2
Multiprocess wall time [sampling interval: 10]

Multiprocess wall time [sampling interval: 10]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 2940 ± 90 1 ± 0 0.0025 ± 0.0003 304 ± 8
dev 3220 ± 90 1 ± 0 0 ± 0 268 ± 7
Multiprocess wall time [sampling interval: 100]

Multiprocess wall time [sampling interval: 100]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 2860 ± 90 0.07 ± 0.01 0.002 ± 0.0002 311 ± 9
dev 3270 ± 100 0.04 ± 0.003 2e-06 ± 7e-06 265 ± 6
Multiprocess wall time [sampling interval: 1000]

Multiprocess wall time [sampling interval: 1000]

Sample Rate Saturation Error Rate Sampling Speed
3.7.0 2810 ± 60 0.046 ± 0.003 0.00028 ± 9e-05 314 ± 7
dev 3300 ± 60 0.038 ± 0.003 2e-06 ± 7e-06 264 ± 4

@codecov Codecov
Copy link

codecov bot commented Feb 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 65.85366% with 14 lines in your changes missing coverage. Please review.

Project coverage is 68.81%. Comparing base (873203d) to head (4ee62ac).
Report is 4 commits behind head on devel.

Files with missing lines Patch % Lines
src/linux/py_proc.h 65.85% 7 Missing and 7 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##            devel     #257      +/-   ##
==========================================
- Coverage   69.32%   68.81%   -0.52%     
==========================================
  Files          28       28              
  Lines        2595     2597       +2     
  Branches      796      796              
==========================================
- Hits         1799     1787      -12     
- Misses        455      461       +6     
- Partials      341      349       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@P403n1x87 P403n1x87 marked this pull request as ready for review February 24, 2025 15:15
@P403n1x87 P403n1x87 merged commit 92481af into devel Feb 24, 2025
38 of 47 checks passed
@P403n1x87 P403n1x87 deleted the chore/small-cleanups branch February 24, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@P403n1x87