Skip to content

Fix crashes that happen during mip map generation #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mateuszstompor merged 1 commit into from
Jan 22, 2026
Merged

Fix crashes that happen during mip map generation #356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Engine/Core/Extensions/ModelIO/MDLTexture+Extension.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ import ModelIO
import simd

extension MDLTexture {
var canBeMipMapped: Bool {
dimensions.x >= 2 && dimensions.y >= 2
}
static func solid2D(color: simd_float4, name: String) -> MDLTexture {
MDLTexture(data: Data.solid2DTexture(color: color),
topLeftOrigin: true,
Expand All @@ -23,7 +26,7 @@ extension MDLTexture {
generateMipMaps: Bool = true) -> MTLTexture? {
let loader = MTKTextureLoader(device: device)
let options: [MTKTextureLoader.Option: Any] = [
.generateMipmaps: true,
.generateMipmaps: canBeMipMapped && generateMipMaps,
.textureUsage: NSNumber(value: usage.rawValue),
.textureStorageMode: NSNumber(value: storageMode.rawValue)
]
Expand Down
Loading