Fix internet access audit to recognize IP/CIDR and zone-scoped firewall rules#220
Merged
tvancott42 merged 3 commits intomainfrom Feb 5, 2026
Merged
Fix internet access audit to recognize IP/CIDR and zone-scoped firewall rules#220tvancott42 merged 3 commits intomainfrom
tvancott42 merged 3 commits intomainfrom
Conversation
IsInternetBlockedViaFirewall only checked SourceMatchingTarget == "NETWORK", missing rules that block via IP/CIDR sources. Use AppliesToSourceNetwork() which handles NETWORK, IP/CIDR, and ANY source types. Also fixed the same issue in FirewallRuleAnalyzer.MatchesInternetTrafficPattern().
AppliesToSourceNetwork and AppliesToDestinationNetwork now check that the rule's zone matches the network's zone before matching by ID, IP/CIDR, or ANY. This prevents rules scoped to a custom zone from falsely matching networks in other zones. Removed redundant zone checks from HasNetworkPair since the logic is now centralized. Added InternalsVisibleTo for direct unit testing of internal methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Source: Network. Rules that block internet via IP/CIDR-based sources (e.g.,192.168.99.0/24) were ignored, causing false "Has Internet" findings.Test plan
dotnet build- 0 warnings,dotnet test- 4,594 tests passsourceMatch=IPin logs for CIDR-based rules