Remove outdated reference to swapchain#285
Merged
Overv merged 1 commit intoOverv:masterfrom May 2, 2022
Merged
Conversation
This commit removes leftover references to the number of swapchain images in the "Uniform buffers" chapter.
charles-lunarg
approved these changes
May 2, 2022
Contributor
charles-lunarg
left a comment
charles-lunarg
left a comment
There was a problem hiding this comment.
Whoops! My bad.
Thanks for the cleanup.
(just offering my approval that this fixes the issue)
Overv
pushed a commit
that referenced
this pull request
Mar 8, 2023
This commit removes leftover references to the number of swapchain images in the "Uniform buffers" chapter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes leftover references to the number of swapchain
images in the "Uniform buffers" chapter.
This seems to be an error introduced by the #255 PR.
Just wanted to say a big THANK YOU to everyone who has contributed to this tutorial, it's the only thing making Vulkan approachable!