Skip to content

Conversation

@opxdelwin
Copy link
Contributor

@opxdelwin opxdelwin commented May 20, 2024

As per #47 t's noted that the itemBuilder returns the documentSnapshot of the document in the given index, which is being iterated on. I'd like to get the list of snapshots from the firebase query, which would help me group the snapshots as per requirements.

This was personal impln of the fork, it's yet pending

  • Tests,
  • Examples, and
  • Manual Optimization to catch excess builds

Copy link
Owner

@OutdatedGuy OutdatedGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change required, otherwise looks good. Will test afterwards.

@opxdelwin opxdelwin requested a review from OutdatedGuy May 23, 2024 16:52
Copy link
Owner

@OutdatedGuy OutdatedGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Will test and approve changes as I get some time.

@opxdelwin
Copy link
Contributor Author

opxdelwin commented May 24, 2024

There's again one more thing, lets say we want to group the documents by a common field, lets say category.

Lets say I ordered it as an expandable panel, with each document inside it. It'll get messy while implementation, as the package takes care of the listview build, and would generate expendable panels with item count of the entire snapshot.

I hope it makes sense

@OutdatedGuy
Copy link
Owner

@opxdelwin Sorry, I don't understand what you mean by that. Can you elaborate and give an example?

@opxdelwin
Copy link
Contributor Author

In short, rather than building the view ourselves, we'll put the responsibility to the user. Hence in that case, we'll have to build 1 time in the package, rather than items.length

@OutdatedGuy
Copy link
Owner

In short, rather than building the view ourselves, we'll put the responsibility to the user. Hence in that case, we'll have to build 1 time in the package, rather than items.length

It true that this method will be more efficient, but would need a similar builder with all these logic and checks. I'm currently very busy to look into it, but you are welcome to create a separate PR for that.

Copy link
Owner

@OutdatedGuy OutdatedGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OutdatedGuy OutdatedGuy merged commit 484162c into OutdatedGuy:main Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants