-
-
Notifications
You must be signed in to change notification settings - Fork 14
return entire snapshot, instead of one doc a time #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
OutdatedGuy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change required, otherwise looks good. Will test afterwards.
OutdatedGuy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Will test and approve changes as I get some time.
|
There's again one more thing, lets say we want to group the documents by a common field, lets say category. Lets say I ordered it as an expandable panel, with each document inside it. It'll get messy while implementation, as the package takes care of the listview build, and would generate expendable panels with item count of the entire snapshot. I hope it makes sense |
|
@opxdelwin Sorry, I don't understand what you mean by that. Can you elaborate and give an example? |
|
In short, rather than building the view ourselves, we'll put the responsibility to the user. Hence in that case, we'll have to build 1 time in the package, rather than |
It true that this method will be more efficient, but would need a similar builder with all these logic and checks. I'm currently very busy to look into it, but you are welcome to create a separate PR for that. |
OutdatedGuy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
As per #47 t's noted that the
itemBuilderreturns thedocumentSnapshotof the document in the given index, which is being iterated on. I'd like to get the list of snapshots from the firebase query, which would help me group the snapshots as per requirements.This was personal impln of the fork, it's yet pending