Skip to content

refactor!: make dispose method asynchronous #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OutdatedGuy merged 2 commits into from
Jul 23, 2025
Merged

refactor!: make dispose method asynchronous #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f94a5fd
refactor!: make dispose method asynchronous
OutdatedGuy Jul 23, 2025
0f6be2e
docs: update example to await dispose
OutdatedGuy Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion example/lib/pages/pre_caching_page.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,9 @@ class _PreCachingPageState extends State<PreCachingPage> {
DataSourceType? _dataSourceType;

Future<void> _playVideo(_VideoInfo videoInfo) async {
await _player?.dispose();

setState(() {
_player?.dispose();
_player = CachedVideoPlayerPlus.networkUrl(videoInfo.url);
_selectedVideo = videoInfo;
});
Expand Down
5 changes: 3 additions & 2 deletions lib/src/cached_video_player_plus.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,10 +388,11 @@ class CachedVideoPlayerPlus {
///
/// Call this method when the video player is no longer needed to free up
/// resources and prevent memory leaks.
void dispose() {
Future<void> dispose() {
if (_isInitialized) {
_videoPlayerController.dispose();
return _videoPlayerController.dispose();
}
return Future.value();
}

/// Removes the cached file for this video player's data source.
Expand Down