feat: function to clear existing video cache#14
Merged
OutdatedGuy merged 4 commits intoOutdatedGuy:mainfrom May 23, 2024
Merged
feat: function to clear existing video cache#14OutdatedGuy merged 4 commits intoOutdatedGuy:mainfrom
OutdatedGuy merged 4 commits intoOutdatedGuy:mainfrom
Conversation
Contributor
chorauoc
commented
Mar 21, 2024
chorauoc
commented
- Added removeFileFromCache function to clear cache and get storage entry
- Exposed getter for isDisposed to check if player already disposed
- Added clearCache function to clear all cache and get storage
- Added addListener override method to prevent exception to be thrown when attempting to add a listener after the controller has already been disposed
- Code refactor
Owner
|
Thanks for the contribution! I'll review the code when I get some free time. |
OutdatedGuy
requested changes
Mar 25, 2024
Owner
OutdatedGuy
left a comment
OutdatedGuy
left a comment
There was a problem hiding this comment.
Looks like a lot of formatting are changed.
Can you first run dart fix --apply and then dart format .
OutdatedGuy
added
the
enhancement
Contributor
Author
|
Formatted as requested |
OutdatedGuy
requested changes
Mar 26, 2024
Owner
OutdatedGuy
left a comment
OutdatedGuy
left a comment
There was a problem hiding this comment.
Thanks for the contribution. There are some changes I have requested. Please resolve them and we can merge this PR.
Owner
|
Hi @chorauoc, are you still working on this PR? |
…ntry - Exposed getter for isDisposed to check if player already disposed - Added clearCache function to clear all cache and get storage - Added addListener override method to prevent exception to be thrown when attempting to add a listener after the controller has already been disposed - Code refactor
OutdatedGuy
force-pushed
the
feature/clear-cache
branch
from
2f6cdbd to
6eaa5cd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.