feat: Default attributes get added to all spans #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows creating RequestTracing with default attributes that will get included in all spans created by the middleware. This is useful for e.g. Datadog where you would always want to include `version` and `span.type`
jtescher
requested changes
Jul 28, 2022
There was a problem hiding this comment.
This is great @nossrannug. One small thing, could we name the method with_extra_attributes or some other name that suggests the attributes are additive as opposed to a replacement for the existing span attributes that are set by default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows creating RequestTracing with default attributes that will
get included in all spans created by the middleware. This is useful for
e.g. Datadog where you would always want to include
versionandspan.type