Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMET-3491 :: Adds Error Page when opening with web view #9

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

OS-martacarlos
Copy link
Contributor

@OS-martacarlos OS-martacarlos commented Jul 4, 2024

Description

Adds a custom error page when opening urls in the webview

Context

https://outsystemsrd.atlassian.net/browse/RMET-3491

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality not to work as expected)

Screenshots (if appropriate)

image image

Checklist

  • Pull request title follows the format RNMT-XXXX <title>
  • Code follows the code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
    • Documentation has been updated accordingly

@OS-martacarlos OS-martacarlos self-assigned this Jul 4, 2024
@OS-martacarlos OS-martacarlos force-pushed the feat/RMET-3491/add-error-page branch from e60012c to 8e463d4 Compare July 4, 2024 16:03
@OS-martacarlos OS-martacarlos marked this pull request as ready for review July 4, 2024 16:15
@OS-martacarlos OS-martacarlos requested a review from a team as a code owner July 4, 2024 16:15
@OS-martacarlos OS-martacarlos requested review from ItsChaceD, IT-MikeS, alexgerardojacinto and OS-ricardomoreirasilva and removed request for a team July 4, 2024 16:15
@OS-martacarlos OS-martacarlos force-pushed the feat/RMET-3491/add-error-page branch from 8e463d4 to 1ec6144 Compare July 4, 2024 16:16
@OS-martacarlos OS-martacarlos force-pushed the feat/RMET-3491/add-error-page branch from 629e40a to c5d6192 Compare July 5, 2024 09:50
Copy link

sonarqubecloud bot commented Jul 5, 2024

@OS-martacarlos OS-martacarlos merged commit aea8c39 into development Jul 5, 2024
3 checks passed
@OS-ricardomoreirasilva OS-ricardomoreirasilva deleted the feat/RMET-3491/add-error-page branch July 12, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants