Skip to content

Conversation

andredestro
Copy link
Contributor

Description

This PR fixes an issue where dismissing an alert view triggered the onBrowserClosed event.

Context

https://outsystemsrd.atlassian.net/browse/RMET-4500

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality not to work as expected)

Tests

Screenshots (if appropriate)

Checklist

  • Pull request title follows the format RNMT-XXXX <title>
  • Code follows the code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
    • Documentation has been updated accordingly

@andredestro andredestro self-assigned this Sep 15, 2025
@cssecautomation
Copy link

cssecautomation commented Sep 15, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

license/snyk check is complete. No issues have been found. (View Details)

code/snyk check is complete. No issues have been found. (View Details)

@andredestro andredestro marked this pull request as ready for review September 15, 2025 15:53
@andredestro andredestro requested a review from a team as a code owner September 15, 2025 15:53
@alexgerardojacinto
Copy link

Should we use conventional commits for the PR title?

So it would be something like: fix: WebView close button error

@andredestro andredestro changed the title RMET-4500 ::: InAppBrowser 3.2.0 close button error fix: WebView close button error Sep 15, 2025
@alexgerardojacinto
Copy link

Tested in iOS 18 (iPhone 11) and it works properly - the OnBrowserClosed event isn't triggered anymore when dismissing JS alerts.

@andredestro andredestro merged commit cafe539 into main Sep 15, 2025
4 of 5 checks passed
@andredestro andredestro deleted the fix/RMET-4500/dismiss-view-issue branch September 15, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants