Fix build number algo to use both methods #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some early steampipe builds use the typical version number print like pre-steampipe which does not work with the version command backtracing method (at least at the time of writing).
Contributor
|
If you're printing out msg/warning that aren't directly caused by user input (in this case there's other features which might get the game build programmatically), then you should do something like |
lipsanen
requested changes
Jan 22, 2026
Collaborator
lipsanen
left a comment
lipsanen
left a comment
There was a problem hiding this comment.
Nice stuff, small nitpick along the lines of what Uncrafted said
Contributor
|
When the environment variable |
lipsanen
approved these changes
Jan 22, 2026
Collaborator
someone ™️ can do this in another PR |
Collaborator
|
tyvm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some early steampipe builds use the typical version number print like pre-steampipe which does not work with the version command backtracing method (at least at the time of writing).