Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复Stfld与Ldfld当对象为适配器时的异常 #655

Merged
merged 2 commits into from
Feb 10, 2022
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions ILRuntime/Runtime/Intepreter/ILIntepreter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -2105,9 +2105,13 @@ public object Run(ILMethod method, object instance, object[] p)

if (obj != null)
{
if (obj is ILTypeInstance)
ILTypeInstance instance = null;
if (obj is ILTypeInstance ilTypeInstance)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请不要使用c# 7以上的语法,会导致老版本Unity无法使用,需要修改

instance = ilTypeInstance;
else if (obj is CrossBindingAdaptorType crossBindingAdaptorType)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

instance = crossBindingAdaptorType.ILInstance;
if (instance != null)
{
ILTypeInstance instance = obj as ILTypeInstance;
val = esp - 1;
instance.AssignFromStack((int)ip->TokenLong, val, AppDomain, mStack);
}
Expand Down Expand Up @@ -2237,11 +2241,13 @@ public object Run(ILMethod method, object instance, object[] p)
Free(ret);
if (obj != null)
{
if (obj is ILTypeInstance)
{
ILTypeInstance instance = obj as ILTypeInstance;
ILTypeInstance instance = null;
if (obj is ILTypeInstance ilTypeInstance)
instance = ilTypeInstance;
else if (obj is CrossBindingAdaptorType crossBindingAdaptorType)
liiir1985 marked this conversation as resolved.
Show resolved Hide resolved
instance = crossBindingAdaptorType.ILInstance;
if (instance != null)
instance.PushToStack((int)ip->TokenLong, ret, this, mStack);
}
else
{
//var t = obj.GetType();
Expand Down
20 changes: 20 additions & 0 deletions TestCases/InheritanceTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,26 @@ public static void InheritanceTest20()
}
}

CrossClass crossClass;
public static void InheritanceTest21()
{
var inheritanceTest = new InheritanceTest();
var dic = new Dictionary<int, CrossClass>();
dic.Add(1, new CrossClass());
dic.TryGetValue(1, out inheritanceTest.crossClass);
Console.WriteLine("InheritanceTest21:classA is " + inheritanceTest.crossClass.classA);
}

public static void InheritanceTest22()
{
var inheritanceTest = new InheritanceTest();
var dic = new Dictionary<int, CrossClass>();
dic.Add(1, new CrossClass());
dic.TryGetValue(1, out inheritanceTest.crossClass);
inheritanceTest.crossClass.classA = new ClassA();
Console.WriteLine("InheritanceTest21:classA is " + inheritanceTest.crossClass.classA);
}

class TestExplicitInterface : IDisposable
{
public bool Called { get; set; }
Expand Down