Use unchecked list when in non-debug mode #48
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In profiling, the default mono List implementation is rather slow, which has a measurable impact with interactions of the managed stack -- for example the
RemoveAt
operation duringFree
performs aShift
andClear
operation even thought it is just removing the end of the list.This PR drops in the latest List implementation of the .NET core and removes additional contract/bounds checks to speed it up. (Note it will only be used outside of DEBUG mode)