Clear stack regardless of if in debug mode #45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's intended to save CPU time for release build, because not zeroing out the stack shouldn't affect the behavior of the result, If you are getting exception while runtime. then it's most probably a bug in other section. Can you please submit a test case for the problem you encountered? So I can look into this issue |
|
Ah, this was a bug due to my other patch #43 (which is now updated) I missed a few ifdefs. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes what I think may have been a bug (I get errors otherwise) where the top of the stack is not cleared out unless in Debug mode. I am not sure if this is a bug directly or is exposing some other underlying problem. If this patch is not applied and Debug mode is disabled, then I get an exception on array bounds when running a simple script. (Happy to investigate further if this patch looks incorrect.)