Revert "Merge pull request #209 from Ouranosinc/magpie-unauthorized-thredds" #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hredds" This reverts commit 6ab2ae8, reversing changes made to 947ea40. Production has not been upgraded to the broken Magpie (PR bird-house/birdhouse-deploy#107) so this revert is so that Jenkins pass again on production.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
tlvu
added a commit
to bird-house/birdhouse-deploy
that referenced
this pull request
Mar 26, 2021
Revert "Merge pull request #107 from bird-house/magpie-thredds" This reverts commit 7be3eea, reversing changes made to c0ffb41. PR #107 upgrade path is unstable, see issue Ouranosinc/Magpie#403 and issue Ouranosinc/Magpie#401. Revert so we can remove the autodeploy block on production instances and give us time to properly test any upcoming fixes. Also unblock Finch to go to production #138. Branch https://github.com/bird-house/birdhouse-deploy/tree/restore-previous-broken-magpie-upgrade-so-we-can-work-on-a-fix created so we have a place to work on a fix. Matching notebooks revert: Ouranosinc/pavics-sdi#211
tlvu
deleted the
revert-change-for-new-broken-magpie-to-fix-jenkins-in-production
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6ab2ae8, reversing changes made to 947ea40.
Production has not been upgraded to the broken Magpie (PR bird-house/birdhouse-deploy#107) so this revert is so that Jenkins pass again on production.
Jenkins build: https://daccs-jenkins.crim.ca/job/PAVICS-e2e-workflow-tests/job/master/242/console
The
finch-usage.ipynbfailure is due to bird-house/finch#161 (comment), a new Finch will be deployed to prod soon (bird-house/birdhouse-deploy#138). Otherwise, with this revert, production will be green.The original #209 is back in branch https://github.com/Ouranosinc/pavics-sdi/tree/restore-change-for-new-broken-magpie-so-we-can-test-magpie-fix so we can test new Magpie with fix.
Matching PAVICS stack revert: bird-house/birdhouse-deploy#137