Skip to content

Commit

Permalink
Merge pull request #66 from Ouranosinc/new-magpie-auth-test-should-be…
Browse files Browse the repository at this point in the history
…-disabled-by-default

jenkins: set TEST_MAGPIE_AUTH default value to false

It was agreed the default value was supposed to be `false` in comment
#55 (comment).

Another reason to keep this option to `false` by default, is this entire
Jenkins test suite also runs nightly on production instances so the admin
password on production instances will never be the default value, for security
reason, so this new notebook activated by `TEST_MAGPIE_AUTH` will never pass.
  • Loading branch information
tlvu authored Mar 25, 2021
2 parents 37df0a6 + bef4b0b commit f194b37
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ pipeline {
// The script attempts to remove everything, but could be incapable of doing so if Magpie become inaccessible
// midway during execution. Employed users/groups are not critical (not modifying existing users permissions),
// but could 'pollute' the user list over time.
booleanParam(name: 'TEST_MAGPIE_AUTH', defaultValue: true,
booleanParam(name: 'TEST_MAGPIE_AUTH', defaultValue: false,
description: '''Check the box to test Authentication/Authorization using Magpie/Twitcher services.
Note: This test suite might require manual clean-up on failure (if critical error).
''')
Expand Down

0 comments on commit f194b37

Please sign in to comment.