Issue 60 signin routes #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmigneault
force-pushed
the
issue-60_signin-routes
branch
from
ebb25f7
to
de2cc1e
Compare
fmigneault
force-pushed
the
issue-60_signin-routes
branch
from
de2cc1e
to
02d4bd2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is WIP
address issue #60
Done
/signinroute for internal/external APIsignin_internalis auto-managed by ziggurat for loginsignin_externaluses the authomatic login, but none really works...Mapping
/signin(provider_name='ziggurat') =>/signin_internal/signin(provider_name=external provider) =>/signin_external=>/providers/{provider}/signinStill under investigation
/providers/{provider}/signin? (do everything in/signin_external)Possible workaround to avoid many sign in routes
/signincould maybe be used to first (always) attempt login locally via the auto ziggurat mapping, then on failure, check if an external provider was specified and, if so, run the corresponding operation...would remove any need of
/signin_internal//signin_external