-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dist to pypi as pavics-magpie #518
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
=======================================
Coverage 80.27% 80.27%
=======================================
Files 71 71
Lines 9615 9616 +1
Branches 1323 1323
=======================================
+ Hits 7718 7719 +1
Misses 1597 1597
Partials 300 300
Continue to review full report at Codecov.
|
@dbyrns Because there was a discussion about that recently, I gave a try to publish Magpie to PyPI. I found the issues listed in the PR description. Some of them make me feel it is not worth doing the change because it introduces a breaking change on existing platforms (mounted INI file in dockers). |
If there is no hard requirement for a pypi package, keeping this as a nice to have is ok. |
Blocking Issues
PyPI requires that all
dist_require
packages are publicly accessible usingpip install <pkg>
.Because of this, URL commit/branch references are not permitted.
The package distribution is blocked by the following PR (so new official versions are published) until Mapgie can be pushed as well:
Breaking Change
Big downside, INI is not backward compatible.
Because
magpie
is already taken on PyPI, and that the INI paste deploy loads using the same distribution name, all existing INI file references will have to change their reference topavics-magpie
.ToDo
If we move on with this change, following must be done:
PYPI_API_TOKEN
secret to repo to allow upload of tagged version by CI