Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI user edit fields error message #371

Merged
merged 4 commits into from
Nov 20, 2020
Merged

Fix UI user edit fields error message #371

merged 4 commits into from
Nov 20, 2020

Conversation

fmigneault
Copy link
Collaborator

@fmigneault fmigneault commented Nov 20, 2020 •
edited
Loading

Example below of displayed contextual error after [password 'Edit', set invalid value, 'Save' button] sequence

image

@github-actions github-actions bot added ci Something related to code tests, deployment and packaging doc Documentation improvements or building problem security New security features or failing AuthN/AuthZ conditions tests Test execution or additional use cases ui Something related to the UI operations or display labels Nov 20, 2020
@fmigneault fmigneault changed the title Fix ui edit pwd Fix UI user edit fields error message Nov 20, 2020
tlvu
tlvu approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@tlvu tlvu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new screenshot with the error LGTM :D

@fmigneault fmigneault merged commit 0e79b8f into master Nov 20, 2020
@fmigneault fmigneault deleted the fix-ui-edit-pwd branch November 20, 2020 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlvu tlvu tlvu approved these changes

@dbyrns dbyrns dbyrns approved these changes

Assignees
No one assigned
Labels
ci Something related to code tests, deployment and packaging doc Documentation improvements or building problem security New security features or failing AuthN/AuthZ conditions tests Test execution or additional use cases ui Something related to the UI operations or display
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmigneault @dbyrns @tlvu