Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return statement #191

Merged
merged 3 commits into from
Jun 25, 2019
Merged

Add return statement #191

merged 3 commits into from
Jun 25, 2019

Conversation

dbyrns
Copy link
Contributor

@dbyrns dbyrns commented Jun 21, 2019

Found that while setupping a dev env. Probably never caused an issue before because the MAGPIE_LOG_LEVEL was always defined.

@dbyrns dbyrns requested a review from fmigneault June 21, 2019 19:00
@codecov-io
Copy link

codecov-io commented Jun 21, 2019

Codecov Report

Merging #191 into master will decrease coverage by 0.04%.
The diff coverage is 13.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
- Coverage   71.99%   71.94%   -0.05%     
==========================================
  Files          94       94              
  Lines        6773     6779       +6     
==========================================
+ Hits         4876     4877       +1     
- Misses       1897     1902       +5
Impacted Files Coverage Δ
magpie/utils.py 61.5% <ø> (ø) ⬆️
magpie/definitions/typedefs.py 0% <0%> (ø) ⬆️
magpie/constants.py 94.4% <100%> (+0.04%) ⬆️
magpie/services.py 44.04% <7.69%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63a7e2c...7103cc8. Read the comment docs.

Copy link
Collaborator

@fmigneault fmigneault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbyrns
I've added the changes returning Permission enum as discussed.

@dbyrns dbyrns merged commit 39de50a into master Jun 25, 2019
@fmigneault fmigneault deleted the missing_return_fix branch December 3, 2019 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants