Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New adapter #184

Merged
merged 6 commits into from
May 24, 2019
Merged

New adapter #184

merged 6 commits into from
May 24, 2019

Conversation

fmigneault
Copy link
Collaborator

waiting on bird-house/twitcher#77 to allow merge & build of new docker image with twitcher+magpie_adapter
resolves #182

@fmigneault fmigneault added enhancement Improvements in term of performance or behaviour feature New feature to be developed security New security features or failing AuthN/AuthZ conditions labels May 22, 2019
@fmigneault fmigneault requested a review from dbyrns May 22, 2019 20:48
@fmigneault fmigneault self-assigned this May 22, 2019
@codecov-io
Copy link

codecov-io commented May 22, 2019

Codecov Report

Merging #184 into master will increase coverage by 2.97%.
The diff coverage is 40.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage    69.2%   72.18%   +2.97%     
==========================================
  Files          95       94       -1     
  Lines        7005     6762     -243     
==========================================
+ Hits         4848     4881      +33     
+ Misses       2157     1881     -276
Impacted Files Coverage Δ
magpie/definitions/twitcher_definitions.py 0% <0%> (ø) ⬆️
magpie/adapter/magpieowssecurity.py 0% <0%> (ø) ⬆️
magpie/adapter/magpieservice.py 0% <0%> (ø) ⬆️
magpie/adapter/__init__.py 0% <0%> (ø) ⬆️
magpie/alembic/env.py 75.6% <0%> (ø) ⬆️
magpie/app.py 92% <100%> (ø) ⬆️
magpie/constants.py 94.3% <100%> (+9.62%) ⬆️
magpie/security.py 93.33% <100%> (+0.31%) ⬆️
magpie/utils.py 65.36% <50%> (+2.67%) ⬆️
magpie/owsrequest.py 45.07% <66.66%> (+1.4%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 901a42c...fccfc8b. Read the comment docs.

@fmigneault fmigneault merged commit 73e433f into master May 24, 2019
@fmigneault fmigneault deleted the new-adapter branch May 24, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements in term of performance or behaviour feature New feature to be developed security New security features or failing AuthN/AuthZ conditions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dockerfile for Twitcher with Magpie adapter
3 participants