Add label to display resources #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the base for a cron service to be ran periodically. The local and remote resource tables are compared when the view is requested.
instead of a 'resource_id' To distinguish permission requests and 'clean_resource' requests
In a thredds catalog, the name of the resource can be capitalized and not its id. But in other cases, both the name and its id are capitalized. We make sure to get the actual id to match the case of the url.
than what was fetched
Too much information was getting pushed to the ui (remote path, remote resource type path) This made it very complicated to implement custom display names for resources, because they would have got to be pushed to the UI also.
Running the migrations from scratch was broken because of the new resource_display_name column. In previous searches like: 'SELECT * FROM resources', resource_display_name was included, but wasn't yet added to the database.
to /resources POST
davidcaron
changed the title
|
is |
davidcaron
changed the title
|
@fmigneault I think I figured it out in c1685e1 how to modify swagger. This is all functional now, as far as I know. Maybe we should wait for #104 before reviewing this. |
|
will wait on PR#104 to be merged, then rebase on top, so that there's less lines to go back through |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on PR #104.
Fixes #98.
@fmigneault, I would need some guidance in swagger to add the optional
resources_display_nameargument to the POST request at path/resources.