fix(jdbc): use configured driver download URLs - #2695
Open
HandSonic wants to merge 1 commit into
Open
Conversation
HandSonic
force-pushed
the
fix/hsqldb-driver-download
branch
from
August 19, 2026 20:16
70b9278 to
fffa3e0
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
openai0229
reviewed
Aug 20, 2026
openai0229
left a comment
openai0229
left a comment
Contributor
There was a problem hiding this comment.
The trusted plugin-config matching, configurable download URL resolution, and active driver-directory creation look correct at this head; I found no standalone logic blocker.
This overlaps JdbcJarUtils heavily with #2687. Please merge #2687 first and rebase this PR onto it, preserving daemon workers, temporary-file writes, atomic replacement, and stale-part cleanup while applying the configured-URL changes. The combined JdbcJarUtils needs its focused tests rerun before approval.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves automatic JDBC driver downloads from trusted plugin metadata instead of request-supplied URLs. Creates the active driver library directory for custom drivers and preserves nested plugin DriverConfig compatibility. Validated by fork frontend/backend CI and Java/JavaScript CodeQL.