fix(clickhouse): encode schema names in JDBC URLs - #2692
Conversation
05a46c2 to
d4e8177
Compare
d4e8177 to
7da9798
Compare
openai0229
left a comment
There was a problem hiding this comment.
Blocking integration issue: this branch still applies encoding on top of the old implementation. That implementation is exactly what #2690 replaces because it cannot reliably preserve IPv6 authorities, no-path URLs, fragments, and other URL shapes. Merging the two fixes independently leaves overlapping implementations and an avoidable conflict.\n\nPlease base this change on #2690's helper and encode the schema as one UTF-8 path segment inside that helper. Keep the reserved-character tests from this PR and the IPv6/query/fragment tests from #2690 so there is one URL-rewrite implementation.
Superseded by a corrected review because shell quoting corrupted the submitted text.
openai0229
left a comment
There was a problem hiding this comment.
Blocking integration issue: this branch still applies encoding on top of the old url.split(connectAddress) implementation. That implementation is exactly what #2690 replaces because it cannot reliably preserve IPv6 authorities, no-path URLs, fragments, and other URL shapes. Merging the two fixes independently leaves overlapping implementations and an avoidable conflict.
Please base this change on #2690's replaceDatabaseInJdbcUrl helper and encode the schema as one UTF-8 path segment inside that helper. Keep the reserved-character tests from this PR and the IPv6/query/fragment tests from #2690 so there is one URL-rewrite implementation.
Summary
Validation
Follow-up regression fix related to #2685 for schema names containing reserved URL characters. This intentionally does not close that issue; the separate IPv6 URL fix is in #2690.