fix(redis): persist no-expiration TTL updates - #2689
Open
HandSonic wants to merge 1 commit into
Open
Conversation
HandSonic
force-pushed
the
fix/redis-persist-no-expiration
branch
2 times, most recently
from
August 12, 2026 17:34
e747220 to
2ece48c
Compare
HandSonic
force-pushed
the
fix/redis-persist-no-expiration
branch
from
August 19, 2026 19:40
2ece48c to
730dea4
Compare
openai0229
previously approved these changes
Aug 20, 2026
openai0229
left a comment
openai0229
left a comment
Contributor
There was a problem hiding this comment.
The TTL transition logic is correct: a positive TTL still emits , and changing an existing non-permanent key to emits without affecting type-replacement flows. Tests cover the command selection. Approved.
openai0229
dismissed
their stale review
August 20, 2026 03:45
Superseded by a corrected review because shell quoting corrupted the submitted text.
openai0229
approved these changes
Aug 20, 2026
openai0229
left a comment
openai0229
left a comment
Contributor
There was a problem hiding this comment.
The TTL transition logic is correct: a positive TTL still emits EXPIRE, and changing an existing non-permanent key to -1 emits PERSIST without affecting type-replacement flows. Tests cover the command selection. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests
Fixes #2681