fix(dashboard): settle failed refresh requests - #2688
Open
HandSonic wants to merge 1 commit into
Open
Conversation
HandSonic
force-pushed
the
fix/dashboard-refresh-settles
branch
from
August 12, 2026 16:49
3175f5a to
aee5e48
Compare
HandSonic
force-pushed
the
fix/dashboard-refresh-settles
branch
from
August 19, 2026 19:43
aee5e48 to
e8ac916
Compare
openai0229
requested changes
Aug 20, 2026
openai0229
left a comment
openai0229
left a comment
Contributor
There was a problem hiding this comment.
Blocking regression: runDashboardRefresh now converts a rejected load into the fulfilled value false, but both callers ignore the boolean. In particular, DingChartModal uses refreshCurrentDashboard().then(() => staticMessage.success(...)), so a failed refresh now displays "pin to dashboard success". Previously that callback did not run on rejection.
Please update callers to distinguish success from failure and use finally for loading cleanup, or preserve rejection while ensuring the refresh button always settles. Add a caller-level test for the failed refresh path, not only the helper test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
Fixes #2682