Skip to content

fix(datasource): require POST to close connections - #2679

Open
HandSonic wants to merge 1 commit into
OtterMind:mainfrom
HandSonic:fix/connection-close-post-only
Open

fix(datasource): require POST to close connections#2679
HandSonic wants to merge 1 commit into
OtterMind:mainfrom
HandSonic:fix/connection-close-post-only

Conversation

@HandSonic

Copy link
Copy Markdown
Contributor

Summary

  • Change /api/connection/close from GET query parameters to a validated POST JSON body because it removes an active connection.
  • Update the sole frontend caller contract for both Web and desktop IPC transports.
  • Add focused frontend and backend contract coverage.

Verification

  • DbDataSourceControllerTest: 1 test passed through the Maven reactor.
  • yarn test:connection-close-request passed.
  • Targeted ESLint and git diff --check passed.
  • Independent adversarial review: PASS, 0 blockers.
  • Fork CI: backend, frontend, Java/JavaScript CodeQL, repository/docs, licenses, and SBOM passed.

Fixes #2678

@HandSonic
HandSonic force-pushed the fix/connection-close-post-only branch from e4d6b0e to 0beebc6 Compare August 11, 2026 13:36
openai0229

This comment was marked as outdated.

@openai0229 openai0229 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The GET-to-POST contract change itself matches #2678: the frontend sends POST /api/connection/close with { id }, and the controller delegates to removeConnection(id). There is no logic blocker in that focused change.

The branch is currently CONFLICTING with main, so it cannot merge as-is. Please rebase and preserve the newer controller/client changes, then rerun the focused frontend request-contract and controller tests. The separate legacy GET /datasource/close endpoint remains a pre-existing no-op and should be handled independently rather than folded into the conflict resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

bug(datasource): connection close mutates state through GET

2 participants