Skip to content

fix(pagination): preserve exact totals across page navigation - #2672

Open
HandSonic wants to merge 1 commit into
OtterMind:mainfrom
HandSonic:fix/pagination-exact-total
Open

fix(pagination): preserve exact totals across page navigation#2672
HandSonic wants to merge 1 commit into
OtterMind:mainfrom
HandSonic:fix/pagination-exact-total

Conversation

@HandSonic

Copy link
Copy Markdown
Contributor

Summary

  • Disable next/last navigation once an exact total reaches the current page boundary.
  • Preserve a user-requested exact COUNT across matching page responses while invalidating it for refreshes, new queries, and stale count responses.
  • Add focused pagination-state coverage.

Verification

  • Fork CI: frontend lint/test/build, backend package, Java/JS CodeQL passed.
  • npx --yes tsx src/components/Pagination/paginationState.test.ts (10 passing)
  • git diff --check
  • adversarial review

@HandSonic
HandSonic force-pushed the fix/pagination-exact-total branch from 325eca9 to 73afcf3 Compare August 11, 2026 13:38
openai0229

This comment was marked as outdated.

@openai0229 openai0229 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exact-total state logic and stale COUNT protection are reasonable at this head, and the focused tests cover the important page-boundary cases. I did not find a separate logic blocker.

This branch is currently CONFLICTING with substantial newer result-toolbar and pagination changes on main. Please rebase and integrate the state machine into the current toolbar instead of resolving by replacing the current files wholesale, then rerun the frontend suite. The rebased result needs a fresh review because the conflict is in the core implementation files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Review

Development

Successfully merging this pull request may close these issues.

2 participants