fix(pagination): preserve exact totals across page navigation - #2672
Open
HandSonic wants to merge 1 commit into
Open
fix(pagination): preserve exact totals across page navigation#2672HandSonic wants to merge 1 commit into
HandSonic wants to merge 1 commit into
Conversation
HandSonic
force-pushed
the
fix/pagination-exact-total
branch
from
August 11, 2026 13:38
325eca9 to
73afcf3
Compare
openai0229
reviewed
Aug 20, 2026
openai0229
left a comment
Contributor
There was a problem hiding this comment.
The exact-total state logic and stale COUNT protection are reasonable at this head, and the focused tests cover the important page-boundary cases. I did not find a separate logic blocker.
This branch is currently CONFLICTING with substantial newer result-toolbar and pagination changes on main. Please rebase and integrate the state machine into the current toolbar instead of resolving by replacing the current files wholesale, then rerun the frontend suite. The rebased result needs a fresh review because the conflict is in the core implementation files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification