fix(oscar): stop leaking internal ROWNUM column on first page of paginated queries - #2304
Merged
Merged
Conversation
… not leaked (code review follow-up)
iamraydoan
added a commit
to iamraydoan/Chat2DB
that referenced
this pull request
Jul 29, 2026
… not leaked (code review follow-up) (OtterMind#2304) Co-authored-by: openai0229 <136558319+openai0229@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes verified review finding tracked in #2281: buildPageLimit appended the ROWNUM inner-select wrapper whenever endRow>0 but the outer wrapper only when startRow>0, so page 1 leaked the internal CHAT2DB_AUTO_ROW_ID column into results (and the downstream header filter only matches the typo'd CAHT2DB spelling used by Oracle/DB2/SqlServer). First page is now wrapped in the outer select so the internal column is stripped. Regression tests added. Verified on fork HandSonic#6 (CI green).