fix(i18n): localize editor custom font tooltip - #2253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #2252
Summary
Replace the hardcoded English custom-font precedence tooltip in Community Editor Settings with
monaco.customFontFamily.tooltip.Add the new key to the English, Simplified Chinese, Japanese, Spanish, and Korean Monaco catalogs, then refresh only the Spanish and Korean
monaco.tsEnglish source hashes required by the repository localization gate.Affected surfaces
Verification
yarn install --frozen-lockfile- passed;yarn.lockremained unchanged.node ./scripts/validate-i18n.cjs --write-source-hashes- passed; updated only the Spanish and Koreanmonaco.tssource hashes.yarn test:i18n- passed; validated Spanish and Korean against 25 frontend modules, two properties bundles, and five READMEs.yarn run lint- passed; ESLint and Stylelint completed with zero warnings.yarn run build:web:community --app_version=0.0.0- passed; related frontend tests passed and Webpack compiled successfully.git diff --check- passed.8891, proxying the healthy Community backend on10825;/workspaceand/api/systemboth returned HTTP 200 and Webpack compiled successfully.Risk and compatibility
Reviewer map
chat2db-community-client/src/blocks/Setting/EditorSetting/index.tsx, then comparesrc/i18n/*/monaco.tsandscripts/i18n-source-hashes.json.Contributor declaration
AI assistance: Substantial AI assistance was used to trace the hardcoded tooltip, prepare translations for the five existing frontend locales, run the repository localization and build gates, and prepare the Issue and PR. The resulting diff and generated source-hash changes were reviewed locally.