Skip to content

fix(i18n): localize editor custom font tooltip - #2253

Merged
openai0229 merged 2 commits into
mainfrom
fix/2252-editor-tooltip-i18n
Jul 27, 2026
Merged

fix(i18n): localize editor custom font tooltip#2253
openai0229 merged 2 commits into
mainfrom
fix/2252-editor-tooltip-i18n

Conversation

@openai0229

Copy link
Copy Markdown
Contributor

Related issue

Closes #2252

Summary

Replace the hardcoded English custom-font precedence tooltip in Community Editor Settings with monaco.customFontFamily.tooltip.

Add the new key to the English, Simplified Chinese, Japanese, Spanish, and Korean Monaco catalogs, then refresh only the Spanish and Korean monaco.ts English source hashes required by the repository localization gate.

Affected surfaces

  • Frontend / Web
  • Backend / API / Storage
  • Database plugin / Driver
  • JCEF / Desktop packaging
  • CI / Build / Release
  • Documentation only

Verification

  • Commands and results:
    • yarn install --frozen-lockfile - passed; yarn.lock remained unchanged.
    • node ./scripts/validate-i18n.cjs --write-source-hashes - passed; updated only the Spanish and Korean monaco.ts source hashes.
    • yarn test:i18n - passed; validated Spanish and Korean against 25 frontend modules, two properties bundles, and five READMEs.
    • yarn run lint - passed; ESLint and Stylelint completed with zero warnings.
    • yarn run build:web:community --app_version=0.0.0 - passed; related frontend tests passed and Webpack compiled successfully.
    • git diff --check - passed.
  • Manual verification: Served the source-tree Community Web build on port 8891, proxying the healthy Community backend on 10825; /workspace and /api/system both returned HTTP 200 and Webpack compiled successfully.
  • UI evidence: N/A - the runtime had no browser-control instance available for an automated language-switch and hover screenshot. The source no longer contains the hardcoded tooltip, and the localization gate verifies the catalog key contract.

Risk and compatibility

  • Public API or stored data: N/A - frontend presentation text only.
  • Database or driver compatibility: N/A - no database or driver code changes.
  • Network, privacy, or security: N/A - no network, credential, or data-flow changes.
  • Community / Local / Pro boundary: The change is limited to the Community frontend source and its existing five locale catalogs; no backend or JCEF resources change.
  • Backward compatibility: The tooltip behavior and custom-font precedence remain unchanged. English wording is tightened without changing meaning, while non-English locales now render translated text instead of English.

Reviewer map

  • Start here: chat2db-community-client/src/blocks/Setting/EditorSetting/index.tsx, then compare src/i18n/*/monaco.ts and scripts/i18n-source-hashes.json.
  • Failure condition: The custom-font tooltip remains hardcoded, any supported locale lacks the key, placeholders or modules drift, or unrelated source hashes change.
  • Rollback or disable path: Revert this PR to restore the previous hardcoded English tooltip.

Contributor declaration

  • I linked the Issue that defines this change.
  • I tested the affected behavior and reported the actual results above.
  • I did not include credentials, private data, or generated build output.
  • I disclosed substantial AI assistance below, or this PR contains no substantial AI-generated code.

AI assistance: Substantial AI assistance was used to trace the hardcoded tooltip, prepare translations for the five existing frontend locales, run the repository localization and build gates, and prepare the Issue and PR. The resulting diff and generated source-hash changes were reviewed locally.

@openai0229
openai0229 merged commit b6b2007 into main Jul 27, 2026
16 checks passed
@openai0229 openai0229 moved this from In Review to Done in Chat2DB Community Jul 27, 2026
@openai0229
openai0229 deleted the fix/2252-editor-tooltip-i18n branch August 5, 2026 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Localize the custom editor font tooltip

1 participant