fix(notification-nav): guard on-mount async queries against unmount - #2074
Merged
openai0229 merged 2 commits intoJul 24, 2026
Merged
Conversation
queryUnreadCount, queryNotificationList, and queryPopNotification fire on mount and resolve into setState calls with no mounted guard. If the component unmounted before the awaits resolved, setState fired on an unmounted component. Track a mounted ref and skip setState after unmount. Fixes OtterMind#2071 Co-Authored-By: Claude <noreply@anthropic.com>
openai0229
approved these changes
Jul 24, 2026
openai0229
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the unmount guards around notification queries and side effects. No blocking findings; LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #2071
Summary
NotificationNavfires three queries on mount (queryNotificationList,queryUnreadCount,queryPopNotification) that resolve intosetStatecalls (setList,setHasUnread,setSPopOpen,setSPopData,setNoSPopOpen,setNoSPopData) with no mounted guard orAbortController. If the component unmounted before the awaits resolved,setStatefired on an unmounted component. Added amountedRef(useRef(true), setfalsein the mount effect's cleanup) and an earlyreturnbeforesetStatein each query function.Affected surfaces
Verification
npx tsc --noEmit -p chat2db-community-client/tsconfig.json— no errors forNotificationNav/index.tsx.npx eslint src/components/NotificationNav/index.tsx— no errors.mountedRef.current === falseguard skips thesetStatecalls. The mount effect setsmountedRef.current = trueon (re)mount andfalseon cleanup (StrictMode-safe).Risk and compatibility
setStateafter unmount; mounted behavior unchanged.Reviewer map
components/NotificationNav/index.tsx—mountedRef = useRef(true), the mountuseEffectsets it true and clears it in cleanup, and each ofqueryUnreadCount/queryNotificationList/queryPopNotificationearly-returns when!mountedRef.current.Contributor declaration
AI assistance: The fix, verification, and PR description were produced with Claude Code assistance.