fix(xterm): dispose Terminal on unmount - #2067
Merged
Merged
Conversation
The mount effect created a Terminal, loaded a FitAddon, registered an onData handler, and opened it, but cleanup only removed the resize listener. Every unmount leaked a full Terminal instance (DOM, renderer, buffers, timers). Dispose the terminal in cleanup; dispose also tears down the loaded addon and onData listener. Fixes OtterMind#2059 Co-Authored-By: Claude <noreply@anthropic.com>
openai0229
approved these changes
Jul 24, 2026
openai0229
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the terminal disposal cleanup on unmount. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #2059
Summary
The
XtermmountuseEffectcalledinitXterm()which creates anew Terminal(), loads aFitAddon, registersxterm.onData(...), and callsxterm.open(...). The cleanup only removed the windowresizelistener — it never calledxterm.dispose(), so every mount/unmount leaked a full Terminal instance (DOM, renderer, buffers, internal timers), plus theonDatadisposable and the FitAddon. AddedxtermRef.current?.dispose()to the cleanup (dispose()also disposes loaded addons and event listeners), and reset the refs.Affected surfaces
Verification
npx tsc --noEmit -p chat2db-community-client/tsconfig.json— no errors forXterm/index.tsx.npx eslint src/components/Xterm/index.tsx— no errors.xterm.dispose()is now called, tearing down the Terminal, the loaded FitAddon, and theonDatalistener.Risk and compatibility
Reviewer map
components/Xterm/index.tsx— theuseEffect([], )cleanup now callsxtermRef.current?.dispose()and resetsxtermRef/fitAddonRefto null.Contributor declaration
AI assistance: The fix, verification, and PR description were produced with Claude Code assistance.