fix(ui): make useAutoScroll smooth flag effective - #2019
Merged
Conversation
scrollToBottom computed behavior as `smooth ? 'auto' : 'auto'`, so both branches returned 'auto' and the smooth flag never produced smooth scrolling. Use 'smooth' when requested. Fixes OtterMind#2014 Co-Authored-By: Claude <noreply@anthropic.com>
3 tasks
openai0229
approved these changes
Jul 24, 2026
openai0229
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the hook call semantics and scrolling behavior. The change makes the existing smooth flag effective without altering the non-streaming path, and the updated Community frontend checks pass. No blocking issues found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #2014
Summary
useAutoScroll.scrollToBottomcomputed the scroll behavior assmooth ? 'auto' : 'auto'. Both branches returned'auto', so thesmoothflag had no effect and smooth scrolling was never applied.Changed the truthy branch to
'smooth'sosmooth ? 'smooth' : 'auto'behaves as intended.
Affected surfaces
Verification
npx tsc --noEmit -p chat2db-community-client/tsconfig.json— no errors reported forhooks/useAutoScroll.ts.'smooth'is a validScrollBehaviorvalue per the DOMScrollToOptions.behaviortype.Risk and compatibility
Reviewer map
hooks/useAutoScroll.ts:24—smooth ? 'auto' : 'auto'->smooth ? 'smooth' : 'auto'.smooth=true.Contributor declaration
AI assistance: The fix, verification, and PR description were produced with Claude Code assistance.