Skip to content

Fix count SQL semicolon trimming - #1966

Merged
openai0229 merged 4 commits into
OtterMind:mainfrom
Aias00:fix/sqlutils-count-trim
Jul 24, 2026
Merged

Fix count SQL semicolon trimming#1966
openai0229 merged 4 commits into
OtterMind:mainfrom
Aias00:fix/sqlutils-count-trim

Conversation

@Aias00

@Aias00 Aias00 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary

  • trim generated count SQL using its own length instead of the original SQL length
  • reuse the same trailing-semicolon helper for fallback count SQL wrapping
  • add focused SqlUtils tests for count SQL semicolon handling

Verification

  • mvn -B -f chat2db-community-server/pom.xml -pl :chat2db-community-spi -am -Dmaven.test.skip=false -DskipTests=false -Dtest=SqlUtilsTest -Dsurefire.failIfNoSpecifiedTests=false -Dmaven.test.failure.ignore=false test
  • mvn -B -f chat2db-community-server/pom.xml -pl :chat2db-community-spi -am -Dmaven.test.skip=true package

Copilot AI review requested due to automatic review settings July 23, 2026 10:50
@Aias00
Aias00 requested a review from openai0229 as a code owner July 23, 2026 10:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Aias00

Aias00 commented Jul 23, 2026

Copy link
Copy Markdown
Contributor Author

close: #1970

@openai0229
openai0229 merged commit 2ed4d9d into OtterMind:main Jul 24, 2026
15 checks passed
@openai0229 openai0229 moved this from In Review to Done in Chat2DB Community Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants