fix(workspace): keep Data Browser active after creating a query - #1930
Closed
yashoncode wants to merge 1 commit into
Closed
fix(workspace): keep Data Browser active after creating a query#1930yashoncode wants to merge 1 commit into
yashoncode wants to merge 1 commit into
Conversation
…the tree
The left sidebar panel selection (activePanel) defaults to 'explorer' (Files)
and only becomes 'database' (Data Browser) as a side effect of locateDatabaseTree.
That setActivePanel('database') was gated behind showExplorerPanel. On desktop the
Java bridge (window.javaQuery) is injected shortly after load, so showExplorerPanel
is briefly false while currentPanel is forced to 'database' -- the user browses the
Data Browser tree even though activePanel is still 'explorer'. Creating a query then
runs the auto-follow locate, which skipped setActivePanel('database') due to the gate,
so once the bridge initialized the sidebar reverted to the stale 'explorer' default
and snapped to Files.
Always record 'database' as the active panel when locating a database-tree target;
only the frame-wait still depends on the explorer panel being mounted.
Fixes OtterMind#1915
Contributor
|
Thanks for working on this. The workspace behavior has now been implemented and merged in #1975 with the finalized rule: Files/Data Browser mode changes only through an explicit user action, while console/tab changes only locate the active item inside the current mode. This branch now conflicts with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.