fix(sqlserver): use ROW_NUMBER pagination for SQL Server < 2012 (#1693) - #1919
Merged
Merged
Conversation
…rMind#1693) When OFFSET...FETCH is unavailable (SQL Server < 2012, version < 11), fall back to ROW_NUMBER() OVER() window function, following the same pattern used by the DB2 plugin. The generated SQL wraps the original query: SELECT * FROM (SELECT TMP_PAGE.*, ROW_NUMBER() OVER(ORDER BY (SELECT NULL)) AS CAHT2DB_AUTO_ROW_ID FROM (<original>) TMP_PAGE) TMP_PAGE WHERE CAHT2DB_AUTO_ROW_ID BETWEEN startRow AND endRow Previously, buildPageLimit returned EMPTY for old versions, causing pagination to silently return all rows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces closed #1895 with correct implementation.
When OFFSET...FETCH is unavailable (SQL Server < 2012), fall back to ROW_NUMBER() OVER() following the same pattern as DB2SqlBuilder. Previously buildPageLimit returned EMPTY causing pagination to silently return all rows.
Fixes #1693