fix(release): isolate gray CDN artifacts - #1882
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #1881
Summary
Manual gray builds previously uploaded to the same CDN keys as formal tag releases, so a same-version gray rerun could replace formal installers, updater payloads, checksums, and the release manifest.
This change keeps the existing formal paths for compatibility and routes each gray run to
community/gray/<version>/<run-id>/, with updater payloads under that run'supdates/directory. Manifest URLs, updater metadata, OSS destinations, package notifications, and summary links all consume the resolved prefixes. Gray runs skip CDN refresh because their URLs are unique; release runs retain stable-path refresh and latest promotion. All workflow notification and failure-summary text is now English.Affected surfaces
Verification
git diff --checkpassed; the workflow has no Chinese-character matches; all three embedded notification Python blocks compile; the extracted bundle-validation step passed gray and release fixtures containing all nine installers.Forbidden.RAM. Follow-up run 29800935405 passed all five platform builds, both macOS notarizations, CDN publication, and the English summary;Refresh Community CDN cache, GitHub Release, and Docker were skipped as designed. The manifest reportschannel: gray, nine package URLs undercommunity/gray/5.3.0/29800935405/, and three updater payload URLs under its nestedupdates/directory. All nine installers,SHA256SUMS,release-manifest.json, and four updater objects return HTTP 200. Formal manifest, updater metadata, latest pointer, and MSI object metadata remained unchanged from the pre-run baseline.Risk and compatibility
Reviewer map
.github/workflows/jcef_release.yml, especiallyResolve release metadata, manifest generation, OSS destinations, and the release-only refresh condition.community/gray/<version>/<run-id>/, a gray run mutates formal or latest objects, or a tag release stops using the existing formal paths and refresh behavior.c65b4e68dand2414f44e. Until fixed, avoid dispatching gray builds for versions that already have a formal release.Contributor declaration
AI assistance: Substantial AI assistance was used to inspect the workflow, implement the scoped-prefix change, update notification text, and prepare verification. The resulting changes were validated with the commands and live workflow runs listed above.