fix(sql): preserve execution context correctness - #1870
Merged
Conversation
14 tasks
Contributor
Author
Cancellation follow-upThis PR now also fixes the persistent
Verification:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #1869
Enterprise equivalent: OtterMind/Chat2DB-Enterprise#97, tracked by Enterprise Issue #95.
Summary
SET LOCAL,DEFAULT, and multi-targetsearch_path.GObatches correctly, bound Output record/message growth, and keep Community execution timing internally consistent.statementSequencewhen structured stream metadata is absent.Affected surfaces
Verification
cd chat2db-community-server && rtk mvn -q clean test install -Dmaven.test.skip=false -DskipTests=false: passed all 48 modules; 866 tests, 0 failures, 0 errors, 1 skipped.cd chat2db-community-client && rtk yarn test:search-result-tab-selection: passed.cd chat2db-community-client && rtk yarn test:sql-execution-log: passed.cd chat2db-community-client && rtk yarn run build:web:community --app_version=5.3.0: passed.rtk git diff --check: passed.SELECT / SELECT / USE / SELECTactivates the final result tab, a successful no-resultUSEactivates Output, and a failedSELECTactivates Output.Risk and compatibility
enterprise-migrationis intentionally unchanged.Reviewer map
DefaultSQLExecutor,JdbcExecutionContext, andSqlServerExecutor; then reviewsqlExecutionLog.tsfor bounded frontend state and event deduplication. For result routing, reviewSQLExecute,SearchResult,tabSelection.ts, andsortExecutionResults.GOreaches the driver, final status/timing is lost when records are bounded, or a successful batch ending in a tabular result leaves Output active.Contributor declaration
AI assistance: Substantial AI assistance was used for implementation, regression tests, browser verification, and cross-repository review.