Skip to content

Commit a93a83d

Browse files
tido64Othinn
authored andcommitted
Correctly declare runtime dependencies (facebook#41398)
Summary: In pnpm setups, codegen will fail during build because it cannot find its dependencies. Some of the dependencies it relies on at runtime are currently declared under `devDependencies`. This change moves them to `dependencies`. ## Changelog: [GENERAL] [FIXED] - Fix `react-native/codegen` not being able to resolve dependencies in pnpm setups Pull Request resolved: facebook#41398 Test Plan: We are currently trying to [enable pnpm mode](microsoft/rnx-kit#2811) in rnx-kit and hit this issue. We've patched this package locally and it works. Reviewed By: christophpurrer Differential Revision: D51169116 Pulled By: NickGerleman fbshipit-source-id: 28906a0de412c660d2fc42f62deaf77240d27a58
1 parent 4b81462 commit a93a83d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

packages/react-native-codegen/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,11 @@
3030
],
3131
"dependencies": {
3232
"@babel/parser": "^7.20.0",
33+
"glob": "^7.1.1",
3334
"hermes-parser": "0.17.1",
35+
"invariant": "^2.2.4",
3436
"jscodeshift": "^0.14.0",
37+
"mkdirp": "^0.5.1",
3538
"nullthrows": "^1.1.1"
3639
},
3740
"devDependencies": {
@@ -46,11 +49,8 @@
4649
"@babel/plugin-transform-flow-strip-types": "^7.20.0",
4750
"@babel/preset-env": "^7.20.0",
4851
"chalk": "^4.0.0",
49-
"glob": "^7.1.1",
5052
"hermes-estree": "0.17.1",
51-
"invariant": "^2.2.4",
5253
"micromatch": "^4.0.4",
53-
"mkdirp": "^0.5.1",
5454
"prettier": "2.8.8",
5555
"rimraf": "^3.0.2"
5656
},

0 commit comments

Comments
 (0)