Correctly declare runtime dependencies #41398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
tido64
force-pushed
the
tido/codegen/npm-dependencies
branch
from
dec22c3
to
81842b3
Compare
|
@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Base commit: 01b4d78 |
|
This pull request was successfully merged by @tido64 in c58e19e. When will my fix make it into a release? | Upcoming Releases |
This was referenced Nov 13, 2023
Othinn
pushed a commit
to Othinn/react-native
that referenced
this pull request
Jan 9, 2024
Summary: In pnpm setups, codegen will fail during build because it cannot find its dependencies. Some of the dependencies it relies on at runtime are currently declared under `devDependencies`. This change moves them to `dependencies`. ## Changelog: [GENERAL] [FIXED] - Fix `react-native/codegen` not being able to resolve dependencies in pnpm setups Pull Request resolved: facebook#41398 Test Plan: We are currently trying to [enable pnpm mode](microsoft/rnx-kit#2811) in rnx-kit and hit this issue. We've patched this package locally and it works. Reviewed By: christophpurrer Differential Revision: D51169116 Pulled By: NickGerleman fbshipit-source-id: 28906a0de412c660d2fc42f62deaf77240d27a58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In pnpm setups, codegen will fail during build because it cannot find its dependencies. Some of the dependencies it relies on at runtime are currently declared under
devDependencies. This change moves them todependencies.Changelog:
[GENERAL] [FIXED] - Fix
@react-native/codegennot being able to resolve dependencies in pnpm setupsTest Plan:
We are currently trying to enable pnpm mode in rnx-kit and hit this issue. We've patched this package locally and it works.