-
Notifications
You must be signed in to change notification settings - Fork 2
Add initial LLM rules #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
|
||
| ### File Complexity | ||
|
|
||
| - **Maximum File Length**: 200 lines |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is realistic, some not complicated backend "services" files normally (now) can have 500-1000 lines.
If we do this, we should change the default structure to be like src/services/serviceName/serviceFile1.ts so they have room to growth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
its a guideline, not lint ;)
reviewing a new 1000 line file will be a chore.
there is an emphasis on changes made should be reviewable within 2 minutes.
| ### Strict Mode Required | ||
|
|
||
| ```json | ||
| // tsconfig.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure LLM needs it as it's already in the project settings and handled by TS-checkers
No description provided.